Author Message

<  Everything Coding  ~  Fix crash on early fail

PostPosted: Wed Jul 20, 2016 9:33 pm Reply with quote
Posts: 23Joined: Wed Jun 22, 2016 2:17 pm

Offline Profile
PostPosted: Thu Jul 21, 2016 9:23 am Reply with quote
Site AdminPosts: 6360Joined: Sat Nov 03, 2007 12:30 am
Hmm, that bug report seems not to be public yet ... Can't see it.

Edit: to be more precise - it says I can't see it without logging in.


Offline Profile
PostPosted: Thu Jul 21, 2016 11:47 am Reply with quote
Posts: 1156Location: Koh Samui, THJoined: Wed Jul 11, 2012 3:14 pm
Logging in doesn't get you any further, the bug seems to be RedHat specific and not something we should care about.

Quote:
You are not authorized to access bug #1358472.

Most likely the bug has been restricted for internal development processes and we cannot grant access.


Offline Profile
PostPosted: Thu Jul 21, 2016 6:53 pm Reply with quote
Posts: 23Joined: Wed Jun 22, 2016 2:17 pm
Sorry, my bad. The bug was automatically filed and I didn't realize it defaults to private. There's nothing secret there; nor too much interesting stuff -- just a traceback and the patch.


Offline Profile
PostPosted: Fri Jul 22, 2016 10:55 am Reply with quote
Site AdminPosts: 6360Joined: Sat Nov 03, 2007 12:30 am
I'll try to wrap the whole thing up because it was not immediately clear to me what this is all about:

There was some automatic Fedora package auditing, and it discovered a crash if the command line parameter "-c" was given a file name of a non-existent file.

Is that correct?

Anyway, I will test this and apply the patch accordingly.
However, the priority is not very high as the "-c" parameter is never used in the standard 'automatic' setup. The bug will affect only people who run usb_modeswitch manually on the command line.


Offline Profile
PostPosted: Fri Aug 18, 2017 10:42 am Reply with quote
Posts: 23Joined: Wed Jun 22, 2016 2:17 pm
No, the testing was not automatic really; I was hunting down another bug (see viewtopic.php?f=2&t=2557) and happened to call the tool with a wrong parameter. The crash was then caught by ABRT which makes it convenient to track the crashes and also saves the core.

Agreed about the severity -- not too important at all.

The another bug hits undefined behavior and indeed makes usb_modeswitch act very unpredictably though; that's a bit more severe. Patched it for Fedora already, but other distros may need a fix too.


Last bumped by lkundrak on Fri Aug 18, 2017 10:42 am.
Offline Profile

Display posts from previous:  Sort by:

All times are UTC + 1 hour [ DST ]
Page 1 of 1
6 posts
Users browsing this forum: No registered users and 1 guest
Search for:
Post new topic  Reply to topic
Jump to:  
You cannot post new topics in this forum
You cannot reply to topics in this forum
You cannot edit your posts in this forum
You cannot delete your posts in this forum
You cannot post attachments in this forum