Search found 24 matches

by lkundrak
24 Mar 2020, 16:47
Forum: Everything Coding
Topic: usb_modeswitch: count the target devices from zero
Replies: 4
Views: 7430

Re: usb_modeswitch: count the target devices from zero

Uh, okay, my bad. Then i is possibly uninitialized though (when devh is unset).
by lkundrak
18 Aug 2017, 10:53
Forum: Everything Coding
Topic: Nokia 0421:0637 won't switch
Replies: 14
Views: 15699

Re: Nokia 0421:0637 won't switch

Sorry for the bump.
Seems like this one has been silently applied and thus the issue is resolved.
by lkundrak
18 Aug 2017, 10:47
Forum: Everything Coding
Topic: usb_modeswitch: fix a wrong comparison
Replies: 0
Views: 12808

usb_modeswitch: fix a wrong comparison

The char pointer should be dereferences when checking the string is empty.
by lkundrak
18 Aug 2017, 10:43
Forum: Everything Coding
Topic: Nokia 0421:0637 won't switch
Replies: 14
Views: 15699

Re: Nokia 0421:0637 won't switch

Looked a bit further into the issue. The phone misbehaves (ignores one message) in most cases when the endpoint is reset prior to issuing the allow remove (0x1e) command. It doesn't seem to happen when the one of the few commands preceding the reset is test unit ready (0x00) which explains why it wo...
by lkundrak
18 Aug 2017, 10:42
Forum: Everything Coding
Topic: A patch for --help
Replies: 0
Views: 12626

A patch for --help

Hi,

It seems that the patch from the following post got applied incompletely
http://www.draisberghof.de/usb_modeswit ... f=2&t=1635

Here's what's left:
http://pkgs.fedoraproject.org/cgit/rpms ... ages.patch

Thank you,
Lubo
by lkundrak
18 Aug 2017, 10:42
Forum: Everything Coding
Topic: Fix crash on early fail
Replies: 5
Views: 7882

Re: Fix crash on early fail

No, the testing was not automatic really; I was hunting down another bug (see http://www.draisberghof.de/usb_modeswitch/bb/viewtopic.php?f=2&t=2557) and happened to call the tool with a wrong parameter. The crash was then caught by ABRT which makes it convenient to track the crashes and also sav...
by lkundrak
09 Nov 2016, 15:53
Forum: Everything Coding
Topic: usb_modeswitch: don't pass busname to the dispatcher
Replies: 2
Views: 5720

Re: usb_modeswitch: don't pass busname to the dispatcher

Whoops, the patch was wrong, since it's the usb_modeswitch-data that passes the %b argument. Updated the patch to keep the compatibility. This is not too nice though. Ideally, the data package should tag the device for the modeswitch with TAG+="usb_modeswitch" rule and then the usb_modeswi...
by lkundrak
09 Nov 2016, 13:49
Forum: Everything Coding
Topic: usb_modeswitch: don't pass busname to the dispatcher
Replies: 2
Views: 5720

usb_modeswitch: don't pass busname to the dispatcher

In the better case it's empty and useless, in worst case it's something very irrelevant (a bus name of a random parent of a device that happens to have one, such as the usb controller) and harmful -- when passed to the dispatcher it appends it to the sysfs path, making it invalid. To add insult to i...
by lkundrak
12 Sep 2016, 14:29
Forum: Everything Coding
Topic: Nokia 0421:0637 won't switch
Replies: 14
Views: 15699

Re: Nokia 0421:0637 won't switch

Hmm, blacklisting sr_mod and cdrom modules fixes the issue.
Need to look into what do they do.
by lkundrak
12 Sep 2016, 14:22
Forum: Everything Coding
Topic: Nokia 0421:0637 won't switch
Replies: 14
Views: 15699

Re: Nokia 0421:0637 won't switch

I think we may get that reply if we only wait long enough for it, can you try to add a delay instead of doing a retry? 100mS could be a reasonable value. The current timeout is 3 seconds. I've previously tried to raise it to 30 seconds, but that didn't change anything. I don't think we are talking ...
by lkundrak
09 Sep 2016, 16:49
Forum: Everything Coding
Topic: Nokia 0421:0637 won't switch
Replies: 14
Views: 15699

Re: Nokia 0421:0637 won't switch

LOM wrote:I think we may get that reply if we only wait long enough for it, can you try to add a delay instead of doing a retry? 100mS could be a reasonable value.
The current timeout is 3 seconds. I've previously tried to raise it to 30 seconds, but that didn't change anything.
by lkundrak
08 Sep 2016, 16:04
Forum: Everything Coding
Topic: Nokia 0421:0637 won't switch
Replies: 14
Views: 15699

Re: Nokia 0421:0637 won't switch

What kind of hardware is the host, a very fast computer? Hopefully not a Raspberry Pi.. According to the DMI it's a ThinkCentre M73 with BIOS dated 12/2015. Doesn't seem like an old machine. Has a 4th i3-4150 CPU and the phone is plugged into an USB 2.0 port of "Intel Corporation 8 Series/C220...
by lkundrak
08 Sep 2016, 12:14
Forum: Everything Coding
Topic: don't return a value from stack
Replies: 3
Views: 6331

Re: don't return a value from stack

There were no other reports about such a problem on other distros, AFAIK. Is there an official Fedora bug report? Not really. I've stumbled upon this myself when checking things work well with my modem collection after updating the package. The users don't tend to include too much details in the bu...