Page 1 of 1

don't return a value from stack

Posted: Thu Jul 21, 2016 6:55 pm
by lkundrak
Please see the attached patch.

Thank you
Lubo

Re: don't return a value from stack

Posted: Wed Sep 07, 2016 8:13 pm
by lkundrak
Ping? This is probably quite serious; at least when built in Fedora the behavior of usb_modeswitch without the patch was totally unpredictable (did the job in ~50% of cases).
Could be the compiler flags we use, but perhaps that happens for other distros too?

Re: don't return a value from stack

Posted: Thu Sep 08, 2016 8:13 am
by Josh
There were no other reports about such a problem on other distros, AFAIK. Is there an official Fedora bug report?

I will certainly include the patch with the next program package update.

Re: don't return a value from stack

Posted: Thu Sep 08, 2016 12:14 pm
by lkundrak
Josh wrote:There were no other reports about such a problem on other distros, AFAIK. Is there an official Fedora bug report?
Not really. I've stumbled upon this myself when checking things work well with my modem collection after updating the package. The users don't tend to include too much details in the bug reports -- there's a handful of "my modem won't work" bug reports filed against ModemManager that lack good explanation. I merely suspected this could be related.